hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jean-Daniel Cryans" <jdcry...@apache.org>
Subject Re: Review Request: HBASE-2223
Date Fri, 28 May 2010 18:55:09 GMT


> On 2010-05-27 12:55:57, Benoit Sigoure wrote:
> > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java, line 378
> > <http://review.hbase.org/r/76/diff/2/?file=669#file669line378>
> >
> >     This seems brittle to me.

Kinda, but it's currently the best I found.


> On 2010-05-27 12:55:57, Benoit Sigoure wrote:
> > src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java, line 385
> > <http://review.hbase.org/r/76/diff/2/?file=669#file669line385>
> >
> >     ?

There are some race conditions currently preventing that to work. Same reason I need to make
sure in this test that the master cluster has all the edits when I kill a region server GC-style.
See this code:

    // Test we actually have all the rows, we may miss some because we
    // don't have IO fencing.
    if (res.length != initialCount) {
      LOG.warn("We lost some rows on the master cluster!");
      // We don't really expect the other cluster to have more rows
      initialCount = res.length;
    }

So if I can lose rows on the master cluster, I can also lose rows on the slave cluster...
but rows that are lost because of a lack of IO-fencing or because of a bug in the replication
will be the same from the client perspective.


> On 2010-05-27 12:55:57, Benoit Sigoure wrote:
> > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java,
line 135
> > <http://review.hbase.org/r/76/diff/2/?file=671#file671line135>
> >
> >     I don't understand why you're doing +=2 and /2 instead of just setting the upper
bound of the loop to BATCH_SIZE/2.

/me feels dumb


> On 2010-05-27 12:55:57, Benoit Sigoure wrote:
> > src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java,
line 198
> > <http://review.hbase.org/r/76/diff/2/?file=672#file672line198>
> >
> >     Uh?  Manual loop unrolling?

Mostly cruft 


- Jean-Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/76/#review86
-----------------------------------------------------------


On 2010-05-26 18:09:30, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/76/
> -----------------------------------------------------------
> 
> (Updated 2010-05-26 18:09:30)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> This is HBASE-2223 AKA Replication 2.0, it is currently only a "preview patch" as it's
pretty much feature complete, works on a cluster, has unit tests and whatnot, but it could
use a lot more testing and cleaning and ideas from others.
> 
> 
> This addresses bug HBASE-2223.
>     http://issues.apache.org/jira/browse/HBASE-2223
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/HConstants.java 13aff26 
>   src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java 4cbe52a 
>   src/main/java/org/apache/hadoop/hbase/master/ServerManager.java a197b8f 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java b5ff43a 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 12a3cd8 
>   src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogKey.java 7c1184c 
>   src/main/java/org/apache/hadoop/hbase/replication/ReplicationZookeeperHelper.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/replication/master/ReplicationLogCleaner.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/package.html PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSink.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceInterface.java
PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java
PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java ed8709f 
>   src/test/java/org/apache/hadoop/hbase/replication/ReplicationSourceDummy.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/TestReplication.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSource.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSink.java
PRE-CREATION 
>   src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSourceManager.java
PRE-CREATION 
> 
> Diff: http://review.hbase.org/r/76/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message