hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@cloudera.com>
Subject Re: Review Request: HBASE-2613
Date Wed, 26 May 2010 22:16:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/89/#review82
-----------------------------------------------------------

Ship it!


A little nervous about the sleeps in the test making it flaky, but let's push it and fix if
it ends up flaky. +1

- Todd


On 2010-05-26 15:12:24, Jean-Daniel Cryans wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/89/
> -----------------------------------------------------------
> 
> (Updated 2010-05-26 15:12:24)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> Patch that removes all the MSG_CALL_SERVER_STARTUP related code that was screwing us
more than helping us. Now, when a region server pings back with a different start code, we
just shut it down.
> 
> 
> This addresses bug HBASE-2613.
> 
> 
> Diffs
> -----
> 
>   /trunk/src/main/java/org/apache/hadoop/hbase/HMsg.java 948611 
>   /trunk/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java 948611 
>   /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 948611

>   /trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterWrongRS.java PRE-CREATION

> 
> Diff: http://review.hbase.org/r/89/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jean-Daniel
> 
>


Mime
View raw message