hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon" <t...@cloudera.com>
Subject Re: Review Request: HBASE-2578
Date Tue, 25 May 2010 19:39:39 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/#review56
-----------------------------------------------------------


Looks good. Few notes:
- Please add the Apache license header to all the new files
- Do we really need to set this up as an instance variable for each HRegion? It seems like
it may be more useful as a global singleton - I'm wondering whether we're going to run into
issues if we try to extend this to do tests that cross HRegion->Store->StoreFile boundaries.
What do you think?


src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java
<http://review.hbase.org/r/83/#comment314>

    may need to be synchronized, or use AtomicLong


- Todd


On 2010-05-25 03:07:25, Daniel Ploeg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/83/
> -----------------------------------------------------------
> 
> (Updated 2010-05-25 03:07:25)
> 
> 
> Review request for hbase.
> 
> 
> Summary
> -------
> 
> HBASE-2578 - Add ability for tests to override server-side timestamp setting (currentTimeMillis).
> The solution in this patch ensures that tests use a different timestamp with a minimal
change to the production code paths.
> One question I would like to know is whether the change that was made to HRegion.FIXED_OVERHEAD
would cause any other side effects.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48 
>   src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java PRE-CREATION

>   src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java PRE-CREATION 
>   src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6 
>   src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java PRE-CREATION

> 
> Diff: http://review.hbase.org/r/83/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel
> 
>


Mime
View raw message