hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Ploeg" <dpl...@gmail.com>
Subject Review Request: HBASE-2578
Date Tue, 25 May 2010 10:07:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/83/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

HBASE-2578 - Add ability for tests to override server-side timestamp setting (currentTimeMillis).
The solution in this patch ensures that tests use a different timestamp with a minimal change
to the production code paths.
One question I would like to know is whether the change that was made to HRegion.FIXED_OVERHEAD
would cause any other side effects.


Diffs
-----

  src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 287cd48 
  src/main/java/org/apache/hadoop/hbase/util/DefaultEnvironmentEdge.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/util/EnvironmentEdge.java PRE-CREATION 
  src/main/java/org/apache/hadoop/hbase/util/IncrementingEnvironmentEdge.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java d3716d6 
  src/test/java/org/apache/hadoop/hbase/util/TestDefaultEnvironmentEdge.java PRE-CREATION

  src/test/java/org/apache/hadoop/hbase/util/TestIncrementingEnvironmentEdge.java PRE-CREATION


Diff: http://review.hbase.org/r/83/diff


Testing
-------


Thanks,

Daniel


Mime
View raw message