hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Rawson" <ryano...@gmail.com>
Subject Re: Review Request: HBASE-2519. Expose IOEs up to client
Date Fri, 21 May 2010 22:53:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.hbase.org/r/75/#review27
-----------------------------------------------------------



src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java
<http://review.hbase.org/r/75/#comment178>

    2 spaces not 1



src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
<http://review.hbase.org/r/75/#comment179>

    why are we creating a reader here? The incoming store file list is already opened... Re-opening
the file might not be the best choice, since if the on-disk situation becomes different from
the in-memory we should probably be failing the compactions.  Thus the code should be like
what it was before only throwing an exception instead of continuing on.



src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
<http://review.hbase.org/r/75/#comment180>

    remove this pointless catch, it just muddles the stack trace



src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
<http://review.hbase.org/r/75/#comment181>

    ditto, remove the try/catch and let the exception bubble up


- Ryan


On 2010-05-21 15:23:07, Todd Lipcon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://review.hbase.org/r/75/
> -----------------------------------------------------------
> 
> (Updated 2010-05-21 15:23:07)
> 
> 
> Review request for hbase and Ryan Rawson.
> 
> 
> Summary
> -------
> 
> In particular fixes issues where a compaction that got an error on one storefile would
happily proceed and just remove all that data. Or a user scan would just show empty results
instead of an error.
> 
> 
> This addresses bug HBASE-2519.
>     http://issues.apache.org/jira/browse/HBASE-2519
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java 70b85af 
>   src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java 3433811 
>   src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java 038a335 
>   src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueHeap.java 70f42dc 
>   src/main/java/org/apache/hadoop/hbase/regionserver/KeyValueScanner.java 657018f 
>   src/main/java/org/apache/hadoop/hbase/regionserver/MinorCompactingStoreScanner.java
4b16540 
>   src/main/java/org/apache/hadoop/hbase/regionserver/Store.java 6c3153b 
>   src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java 52d228b 
>   src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java fde872c 
>   src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 238e804 
>   src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java 55a926f 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java PRE-CREATION

>   src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueHeap.java 228ab2c 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestKeyValueScanFixture.java e1ffcc3

>   src/test/java/org/apache/hadoop/hbase/regionserver/TestMemStore.java 6ed0209 
>   src/test/java/org/apache/hadoop/hbase/regionserver/TestStoreFile.java fd77329 
> 
> Diff: http://review.hbase.org/r/75/diff
> 
> 
> Testing
> -------
> 
> new unit tests
> 
> 
> Thanks,
> 
> Todd
> 
>


Mime
View raw message