hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HBASE-2598) Move NINES and ZEROS to client package and change visibility to default
Date Sat, 22 May 2010 23:37:17 GMT

     [ https://issues.apache.org/jira/browse/HBASE-2598?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-2598.
--------------------------

    Resolution: Won't Fix

Resolving as wont' fix.   I committed the below under the aegis of this issue:

{code}
Index: src/main/java/org/apache/hadoop/hbase/HConstants.java
===================================================================
--- src/main/java/org/apache/hadoop/hbase/HConstants.java       (revision 947348)
+++ src/main/java/org/apache/hadoop/hbase/HConstants.java       (working copy)
@@ -29,12 +29,7 @@
 
   /** long constant for zero */
   static final Long ZERO_L = Long.valueOf(0L);
-
-  //TODO: NINES is only used in HBaseAdmin and HConnectionManager. Move to client
-  //      package and change visibility to default
   static final String NINES = "99999999999999";
-  //TODO: ZEROS is only used in HConnectionManager and MetaScanner. Move to
-  //      client package and change visibility to default
   static final String ZEROES = "00000000000000";
 
   // For migration
{code}

IIRC, the comments were part of an inspiration that would shrink HConstants, if not undo it
altogether, moving all the defines therein out to sit in the classes they belong too.  HConstants
is an abused notion in hbase.  All is dumped in there.

> Move NINES and ZEROS to client package and change visibility to default
> -----------------------------------------------------------------------
>
>                 Key: HBASE-2598
>                 URL: https://issues.apache.org/jira/browse/HBASE-2598
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jeff Hammerbacher
>
> As described in the TODOs in HConstants.java

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message