Return-Path: 
 <hbase-dev-return-17139-apmail-hadoop-hbase-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org
Received: (qmail 78024 invoked from network); 2 Feb 2010 18:32:42 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 2 Feb 2010 18:32:42 -0000
Received: (qmail 62204 invoked by uid 500); 2 Feb 2010 18:32:41 -0000
Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org
Received: (qmail 62161 invoked by uid 500); 2 Feb 2010 18:32:40 -0000
Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hbase-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hbase-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hbase-dev@hadoop.apache.org>
List-Id: <hbase-dev.hadoop.apache.org>
Reply-To: hbase-dev@hadoop.apache.org
Delivered-To: mailing list hbase-dev@hadoop.apache.org
Received: (qmail 62151 invoked by uid 99); 2 Feb 2010 18:32:40 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2010 18:32:40 +0000
X-ASF-Spam-Status: No, hits=-1998.8 required=10.0
	tests=ALL_TRUSTED,FS_REPLICA
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Feb 2010 18:32:39 +0000
Received: from brutus.apache.org (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 86AA1234C1F2
	for <hbase-dev@hadoop.apache.org>; Tue,  2 Feb 2010 10:32:19 -0800 (PST)
Message-ID: <664192540.31121265135539550.JavaMail.jira@brutus.apache.org>
Date: Tue, 2 Feb 2010 18:32:19 +0000 (UTC)
From: "Jean-Daniel Cryans (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-2178) Hooks for replication
In-Reply-To: <1095922181.13131265072178715.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-2178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828703#action_12828703 ] 

Jean-Daniel Cryans commented on HBASE-2178:
-------------------------------------------

bq. I'm not sure I understand why you're making 4 fields public in the ZooKeeperWrapper class, the only one you're accessing in your patch for HBASE-2129 is parentZNode. And for this one I think an accessor would be better.

Agreed.

bq. In scanAddressDirectory, I would declare the List<HServerAddress> list after the check on nodes == null that does an early return. This improves readability and this way you can also invoke the constructor with the exact size of the ArrayList in advance: double win!

Since I return the list, this would not compile. 

bq. In listZnodes, I don't know why you wrapped the arguments around. They fit nicely on one line.

Agreed.

bq. In writeZNode, there's some code in the try-block that's not indented.

Good catch.

bq. Just out of curiosity, why are you moving the import java.foo after the import org.apache.bar?

I will have to ask the IntelliJ authors :P

bq. Also I'm not sure I understand why you removed the call to this.conf.setBoolean("dfs.support.append", true); in setUp in TestHLog.

This is something from the 0.20 era, it should have been removed before.

> Hooks for replication
> ---------------------
>
>                 Key: HBASE-2178
>                 URL: https://issues.apache.org/jira/browse/HBASE-2178
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2178-2.patch, HBASE-2178.patch
>
>
> This issue is about getting all the hooks for mdc replication in core HBase.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.