Return-Path: 
 <hbase-dev-return-17414-apmail-hadoop-hbase-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org
Received: (qmail 58794 invoked from network); 11 Feb 2010 19:08:51 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3)
  by minotaur.apache.org with SMTP; 11 Feb 2010 19:08:51 -0000
Received: (qmail 35068 invoked by uid 500); 11 Feb 2010 19:08:51 -0000
Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org
Received: (qmail 35023 invoked by uid 500); 11 Feb 2010 19:08:51 -0000
Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hbase-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hbase-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hbase-dev@hadoop.apache.org>
List-Id: <hbase-dev.hadoop.apache.org>
Reply-To: hbase-dev@hadoop.apache.org
Delivered-To: mailing list hbase-dev@hadoop.apache.org
Received: (qmail 35013 invoked by uid 99); 11 Feb 2010 19:08:51 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2010 19:08:51 +0000
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 11 Feb 2010 19:08:49 +0000
Received: from brutus.apache.org (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 0968429A0014
	for <hbase-dev@hadoop.apache.org>; Thu, 11 Feb 2010 11:08:28 -0800 (PST)
Message-ID: <1590304910.213281265915308037.JavaMail.jira@brutus.apache.org>
Date: Thu, 11 Feb 2010 19:08:28 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-2208) TableServers #  processBatchOfRows
   -  converts from List to [ ]  - Expensive copy
In-Reply-To: <478533347.169421265766988329.JavaMail.jira@brutus.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HBASE-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832635#action_12832635 ] 

stack commented on HBASE-2208:
------------------------------

FYI: hbase-2209 was committed.

> TableServers #  processBatchOfRows   -  converts from List to [ ]  - Expensive copy 
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-2208
>                 URL: https://issues.apache.org/jira/browse/HBASE-2208
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Kay Kay
>             Fix For: 0.21.0
>
>
> With autoFlush to false and a large write buffer on HTable, when we write bulk puts -  TableServer # processBatchOfRows  , convert the input (List) to an [ ] , before sending down the wire. 
> With a write buffer as large as 20 MB , that becomes an expensive copy when we do   - list.toArray(new T[ ] ). 
> May be - should we change the wire protocol to support List as well , and then revisit this to prevent the bulk copy ?
> {code}
> Batch b = new Batch(this) {
>         @Override
>         int doCall(final List<Row> currentList, final byte [] row,
>           final byte [] tableName)
>         throws IOException, RuntimeException {
>           *final Put [] puts = currentList.toArray(PUT_ARRAY_TYPE);*
>           return getRegionServerWithRetries(new ServerCallable<Integer>(this.c,
>               tableName, row) {
>             public Integer call() throws IOException {
>               return server.put(location.getRegionInfo().getRegionName(), puts);
>             }
>           });
>         }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.