Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 55249 invoked from network); 8 Feb 2010 21:47:52 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 8 Feb 2010 21:47:52 -0000 Received: (qmail 63144 invoked by uid 500); 8 Feb 2010 21:47:51 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 63080 invoked by uid 500); 8 Feb 2010 21:47:51 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 63068 invoked by uid 99); 8 Feb 2010 21:47:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Feb 2010 21:47:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Feb 2010 21:47:49 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 42EBB234C4AD for ; Mon, 8 Feb 2010 13:47:28 -0800 (PST) Message-ID: <1174329730.132251265665648273.JavaMail.jira@brutus.apache.org> Date: Mon, 8 Feb 2010 21:47:28 +0000 (UTC) From: "Kay Kay (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Created: (HBASE-2193) Better readability of - hbase.regionserver.lease.period MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Better readability of - hbase.regionserver.lease.period -------------------------------------------------------- Key: HBASE-2193 URL: https://issues.apache.org/jira/browse/HBASE-2193 Project: Hadoop HBase Issue Type: Improvement Reporter: Kay Kay Property - "hbase.regionserver.lease.period" hardcode would be ideally moved to HConstants. Also - default value seems to be listed all over the place, (thankfully consistent though). That would be nice to be in HConstants too .. $ find . -name \*.java | xargs grep -nr hbase.regionserver.lease.period ./src/contrib/mdc_replication/src/java/org/apache/hadoop/hbase/replication/ReplicationConnectionManager.java:59: this.rpcTimeout = conf.getLong("hbase.regionserver.lease.period", 60000); ./src/java/org/apache/hadoop/hbase/client/HConnectionManager.java:298: this.rpcTimeout = conf.getLong("hbase.regionserver.lease.period", 60000); ./src/java/org/apache/hadoop/hbase/client/HTable.java:121: conf.getInt("hbase.regionserver.lease.period", 60 * 1000); ./src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:271: this.rpcTimeout = conf.getLong("hbase.regionserver.lease.period", 60000); ./src/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:335: conf.getInt("hbase.regionserver.lease.period", 60 * 1000), ./src/test/org/apache/hadoop/hbase/regionserver/TestHRegion.java:1890: conf.setInt("hbase.regionserver.lease.period", 10 * 1000); More of a nit, but provides better readability across. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.