hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryan rawson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2270) Improve how we handle recursive calls in ExplicitColumnTracker and WildcardColumnTracker
Date Thu, 25 Feb 2010 23:00:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12838584#action_12838584
] 

ryan rawson commented on HBASE-2270:
------------------------------------

Thanks JD, this should help the compiler be more optimal, and it should be an easily recognizable
structure for programmers who might recognize the manual tail call optimization. 

A funny aside, the 'continue' lines essentially act like goto statements :-)

> Improve how we handle recursive calls in ExplicitColumnTracker and WildcardColumnTracker
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-2270
>                 URL: https://issues.apache.org/jira/browse/HBASE-2270
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.20.4, 0.21.0
>
>         Attachments: HBASE-2270.patch
>
>
> Ryan was saying in HBASE-2259:
> {quote}
> the variable 'recursive' should really be named something more accurate. the continue
at the end of the loop should get optimized out, but it looks like bad form. also commented
out code should not be in the patch, just remove it.
> since this call is also tail recursive, this should be solvable with a while(true) and
return statements only, no boolean necessary. That would be a more straightforward port, so
lets do that instead.
> {quote}
> Let's fix ExplicitColumnTracker and WildcardColumnTracker at the same time.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message