hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2254) Improvements to the Maven POMs
Date Wed, 24 Feb 2010 11:40:27 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837749#action_12837749
] 

Lars Francke commented on HBASE-2254:
-------------------------------------

No new patch but a few more things I've updated before I forget. Also a few questions

* Updated the assembly descriptor schema version
* The replication contrib wasn't added to the final build (my bad)
* The assembly plugin was complaining about path entries longer than 100 characters. Such
entries can only be processed by GNU compatible tar versions. I disabled this warning.
* CHANGES was missing from final .tar file

Questions/Remarks:
* The current Ant and Ivy files should be removed, they won't work without heavy refactoring,
anyone who tries will in all probability run into problems
* The stargate lib directory and war file now contains _all_ dependencies (even transitive)
instead of only the added dependencies. This adds about 35 MB to the final .tar. I don't know
enough about stargate (have never looked at it) to know if this is a good or a bad thing.
I'll revisit this later but it would be nice if someone could give a short explanation about
what the best behaviour would be
* The .tar file doesn't contain docs, src or webapps directory. There is however a *-source.jar
which seems to be complete and the *.jar does contain the webapps stuff. Your decision if
you want to include the unpacked versions of this. As to the docs: Javadoc generation seems
to be missing, I'll have a look at it
* There are a few deprecation warnings we can't/won't do anything about, mainly in the generated
thrift classes and in the mapred package, I'll see if I can exclude those warnings but I don't
think that's possible

> Improvements to the Maven POMs
> ------------------------------
>
>                 Key: HBASE-2254
>                 URL: https://issues.apache.org/jira/browse/HBASE-2254
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.21.0
>            Reporter: Lars Francke
>            Priority: Minor
>         Attachments: hbase-2254-1.patch, HBASE-2254-2.patch, hbase-2254-3.patch, HBASE-2254-4.patch
>
>
> While the Maven build Paul Smith worked on works mostly wonderfully there are a few small
problems.
> * The version is set to 0.20.2-SNAPSHOT, I've changed it to 0.21.0-SNAPSHOT
> * I reformatted the poms to make them more readable. This is a file that'll unfortunately
be edited by humans so I hope these "whitespace only" changes are acceptable
> * I've introduced the sourceEncoding property to be used instead of the encoding parameters
for the compiler plugins
> * I've changed the plugins section in the main pom to a pluginManagement section and
defined the plugin versions
> * I've fixed a type in the compiler plugin  showDeprecations -> showDeprecation
> I'll continue to go over it but perhaps it already helps.
> I've done a mvn clean assembly:assembly build and everything seems to work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message