Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 31815 invoked from network); 13 Jan 2010 06:40:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Jan 2010 06:40:16 -0000 Received: (qmail 71857 invoked by uid 500); 13 Jan 2010 06:40:16 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 71552 invoked by uid 500); 13 Jan 2010 06:40:16 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 71532 invoked by uid 99); 13 Jan 2010 06:40:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2010 06:40:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 13 Jan 2010 06:40:15 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id E01BE234C1EE for ; Tue, 12 Jan 2010 22:39:54 -0800 (PST) Message-ID: <1499005146.206461263364794916.JavaMail.jira@brutus.apache.org> Date: Wed, 13 Jan 2010 06:39:54 +0000 (UTC) From: "stack (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Updated: (HBASE-2101) KeyValueSortReducer collapses all values to last passed In-Reply-To: <1660478003.140161263065034336.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-2101: ------------------------- Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) Committed to trunk and branch. > KeyValueSortReducer collapses all values to last passed > ------------------------------------------------------- > > Key: HBASE-2101 > URL: https://issues.apache.org/jira/browse/HBASE-2101 > Project: Hadoop HBase > Issue Type: Bug > Reporter: stack > Fix For: 0.20.3, 0.20.4, 0.21.0 > > Attachments: 2102.patch > > > From mailing list by Ioannis Konstantinou: > {code}The problem is in the class org.apache.hadoop.hbase.mapreduce.KeyValueSortReducer. > When you add keyvalues to the treeset for sorting, you need to add keyvalue clones instead of just references. What happens now, is that in every iteration, the value that exists in the treeset gets replaced with the new value. > So, you need to replace line 41 ( map.add(kv);) > with this line: map.add(kv.clone()) > in this case, the treeset populates correcty.{code} > I filed this against 0.20.3 so if we have to cut a new RC, we can include this fix too. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.