hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2151) Remove onelab and include generated thrift classes in javadoc
Date Thu, 21 Jan 2010 03:06:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803149#action_12803149
] 

Lars Francke commented on HBASE-2151:
-------------------------------------

I've missed this, thanks. IDEA hid those warnings well. I learn something new about Thrift
every day. I have a fix and I'll probably attach it tomorrow (seeing as I'm in CET time here
;-) ). 

It requires changes to Hbase.thrift and thus to the generated classes but nothing serious.

Just for reference how a function in Thrift needs to be documented.

{noformat}
  /**
   * Disables a table (takes it off-line) If it is being served, the master
   * will tell the servers to stop serving it.
   */
  void disableTable(
    /** name of the table */
    1:Bytes tableName
  ) throws (1:IOError io)
{noformat}

This is how it is in the current version of Hbase.thrift
{noformat}
  /**
   * Disables a table (takes it off-line) If it is being served, the master
   * will tell the servers to stop serving it.
   * @param tableName name of the table
   */
  void disableTable(1:Bytes tableName) throws (1:IOError io)
{noformat}

This makes the Hbase.thrift file a little bit more ugly but at least the documentation is
correct.

> Remove onelab and include generated thrift classes in javadoc
> -------------------------------------------------------------
>
>                 Key: HBASE-2151
>                 URL: https://issues.apache.org/jira/browse/HBASE-2151
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Lars Francke
>            Priority: Minor
>             Fix For: 0.21.0
>
>
> Patch is actually over in hbase-1373 named javadoc.patch.  It was done by Lars Francke
so I assigned him this issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message