hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Benoit Sigoure (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2156) HBASE-2037 broke Scan
Date Fri, 22 Jan 2010 08:38:21 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803634#action_12803634
] 

Benoit Sigoure commented on HBASE-2156:
---------------------------------------

+1, figured out the bug with JD and verified the patch.
The unit test it's adding could be more minimalist and straight-to-the-point but oh well...

> HBASE-2037 broke Scan
> ---------------------
>
>                 Key: HBASE-2156
>                 URL: https://issues.apache.org/jira/browse/HBASE-2156
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.3
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.20.3
>
>         Attachments: HBASE-2156.patch
>
>
> Paul Ambrose wrote to the mailing list about some tests he has that doesn't pass on 0.20.3RC1-2.
Looking into the issue it appears that this modification:
> {code}
>    public Scan addFamily(byte [] family) {
>      familyMap.remove(family);
> -    familyMap.put(family, null);
> +    familyMap.put(family, EMPTY_NAVIGABLE_SET);
>      return this;
>    }
> {code}
> Makes it that when you use addColumn after that you put qualifiers into EMPTY_NAVIGABLE_SET
which is static hence shared among all scanners after that like META scanners when calling
tableExists.
> This was introduced by HBASE-2037.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message