hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2146) RPC related metrics are missing in 0.20.3 since recent changes
Date Tue, 19 Jan 2010 20:31:54 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802458#action_12802458
] 

Gary Helmling commented on HBASE-2146:
--------------------------------------

Lars,

It looks like these extra metrics are dynamically created and added to the registry via the
HBaseRPCMetrics.inc() and subsequently create() and get() methods.  The org.apache.hadoop.metrics.util.MetricsDynamicMBeanBase
class will update the MBean info if the underlying registry changes (see updateMbeanInfoIfMetricsListChanged()),
but maybe this isn't being invoked everywhere it's needed?

The .inc() method is being called in HBaseRPC.Server.call() with the call method name.  So
it looks like that's how they're getting populated.  -- As an aside it looks like rpcQueueTIme
and rpcProcessingTime are incremented twice there is debug logging is enabled(!) --  I'll
try to test this out as well a bit later.

> RPC related metrics are missing in 0.20.3 since recent changes
> --------------------------------------------------------------
>
>                 Key: HBASE-2146
>                 URL: https://issues.apache.org/jira/browse/HBASE-2146
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.3
>            Reporter: Lars George
>             Fix For: 0.20.4, 0.21.0
>
>         Attachments: jconsole-hbase-rpc.png, jmx-diffs.txt
>
>
> Since the recent change to the Metrics setup it seems that the RPC related stats have
been completely dropped. See attached files for details.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message