hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2029) Reduce shell exception dump on console
Date Sat, 05 Dec 2009 20:30:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786484#action_12786484
] 

stack commented on HBASE-2029:
------------------------------

I took a look.  Issue is in the rpc client:

{code}
        boolean isError = in.readBoolean();     // read if error
        if (isError) {
          call.setException(new RemoteException( WritableUtils.readString(in),
              WritableUtils.readString(in)));
{code}

The second argument is the 'message'.

Here is server-side:

{code}
          try {
            value = call(call.param, call.timestamp);             // make the call
          } catch (Throwable e) {
            LOG.info(getName()+", call "+call+": error: " + e, e);
            errorClass = e.getClass().getName();
            error = StringUtils.stringifyException(e);
          }
{code}

So, changing above so we passed exception class name then message and then cause would change
the ipc.  Since we'd like to get this fix back into 0.20, I'd say lets apply what you fellas
have done up to now -- its way better than what was there -- and then open new issue to make
passing of exceptions cleaner.

On command history, yeah... you can just add config to your .irbrc -- IIRC -- to enable history.
 Should we turn it on as default?  How we tell the case where user doesn't want it?  Or case
where they want more history than ten commands; i.e. we don't want case where they have made
a setting in their irbrc but can't figure why it ain't working.  Maybe can do a if not defined,
set it to history of 100 commands?

> Reduce shell exception dump on console
> --------------------------------------
>
>                 Key: HBASE-2029
>                 URL: https://issues.apache.org/jira/browse/HBASE-2029
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.2
>            Reporter: Lars George
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2029-hirb-v2.patch, HBASE-2029-hirb.patch, HBASE-2029.patch
>
>
> As discussed on IRC and seen over and over, the shell is too verbose when it prints Java
related exceptions. The huge stack trace on the console is often causing more harm then actually
helping.
> {noformat}
> ...
> [11:31pm] larsgeorge:
> the only concern is to keep it in sync with new changes and also reduce its stacktrace
> [11:31pm] larsgeorge:
> that can be quite nasty
> [11:31pm] _dodger_:
> I've seen a prime example of that on the mailing list today
> [11:32pm] larsgeorge:
> yeah, those do repeat themselves
> [11:32pm] larsgeorge:
> also that DEBUG is on by default
> [11:33pm] larsgeorge:
> mind you, that is a good idea for the daemons
> [11:33pm] larsgeorge:
> but prolly not the shell
> [11:33pm] jdcryans:
> I was thinking
> [11:33pm] larsgeorge:
> maybe we can set ERROR logging level just for the shell when it is started?
> [11:34pm] jdcryans:
> we should stop printing the stack trace for NSRE
> [11:34pm] larsgeorge:
> there are a few others of that sort
> [11:34pm] larsgeorge:
> be it ZK reconnects etc.
> [11:35pm] jdcryans:
> yeah there's a lot of hbase-generated zk-related noise
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message