hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dave Latham (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2036) Use Configuration instead of HBaseConfiguration
Date Tue, 15 Dec 2009 00:52:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790498#action_12790498
] 

Dave Latham commented on HBASE-2036:
------------------------------------

If we use object identity, the HCM map will not work as it did.  With the current code, when
you create a new HTable without passing in a HBaseConfiguration object, it instantiates a
new one.  The HCM will find the existing connections/data via the hash map (and hashing of
the data).  The current patch does the same thing via HBaseConfiguration.create().  So if
we changed to only use object identity, then each time you create a new HTable this way, it
will not find the existing TableServers object containing the existing connections & data.
 I think we should move to a internal ConnectionKey that has the hashcode / equals logic as
well as caching of the hash code.  This will preserve the existing behavior and clean up the
Configuration object.

> Use Configuration instead of HBaseConfiguration 
> ------------------------------------------------
>
>                 Key: HBASE-2036
>                 URL: https://issues.apache.org/jira/browse/HBASE-2036
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>         Attachments: hconf.patch
>
>
> HBaseConfiguration extends Configuration but does not add any functionality to it. The
only function is hashCode() which really should be refactored into Hadoop Configuration. 
> I think in all the places(especially in the client side)  HBase methods and classes should
accept Configuration rather than HBaseConfiguration. The creation of the configuration with
the right files (hbase-site and hbase-default) should not be encapsulated in a private method,
but in a public static one. 
> The issues has arisen in our nutch+hbase patch for which we include both nutch configuration
and hbase configurations. Moreover people may want to include separate project-specific configuration
files to their configurations without the need to be dependent on the HBaseConfiguration.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message