hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lars George <lars.geo...@gmail.com>
Subject Re: svn commit: r894799 - in /hadoop/hbase/branches/0.20: CHANGES.txt src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
Date Thu, 31 Dec 2009 10:05:12 GMT
Hi Andy,

Did this fix http://www.mail-archive.com/hbase-user@hadoop.apache.org/msg07734.html
? I missed the issue and had not yet time to test this (as 0.20 does
not have the junit 4 test). If so, does Sandy know already I assume?

Thanks,
Lars

On Thu, Dec 31, 2009 at 10:20 AM,  <apurtell@apache.org> wrote:
> Author: apurtell
> Date: Thu Dec 31 09:20:18 2009
> New Revision: 894799
>
> URL: http://svn.apache.org/viewvc?rev=894799&view=rev
> Log:
> HBASE-2082 TableInputFormat is ignoring input scan's stop row setting
>
> Modified:
>    hadoop/hbase/branches/0.20/CHANGES.txt
>    hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
>
> Modified: hadoop/hbase/branches/0.20/CHANGES.txt
> URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/CHANGES.txt?rev=894799&r1=894798&r2=894799&view=diff
> ==============================================================================
> --- hadoop/hbase/branches/0.20/CHANGES.txt (original)
> +++ hadoop/hbase/branches/0.20/CHANGES.txt Thu Dec 31 09:20:18 2009
> @@ -34,6 +34,8 @@
>                an immediate region server shutdown (Sam Pullara via JD)
>    HBASE-2078  Add JMX settings as commented out lines to hbase-env.sh
>                (Lars George via JD)
> +   HBASE-2082  TableInputFormat is ignoring input scan's stop row setting
> +               (Scott Wang via Andrew Purtell)
>
>   IMPROVEMENTS
>    HBASE-1961  HBase EC2 scripts
>
> Modified: hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
> URL: http://svn.apache.org/viewvc/hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java?rev=894799&r1=894798&r2=894799&view=diff
> ==============================================================================
> --- hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
(original)
> +++ hadoop/hbase/branches/0.20/src/java/org/apache/hadoop/hbase/mapreduce/TableInputFormatBase.java
Thu Dec 31 09:20:18 2009
> @@ -298,8 +298,9 @@
>         byte[] splitStart = startRow.length == 0 ||
>           Bytes.compareTo(keys.getFirst()[i], startRow) >= 0 ?
>             keys.getFirst()[i] : startRow;
> -        byte[] splitStop = stopRow.length == 0 ||
> -          Bytes.compareTo(keys.getSecond()[i], stopRow) <= 0 ?
> +        byte[] splitStop = (stopRow.length == 0 ||
> +          Bytes.compareTo(keys.getSecond()[i], stopRow) <= 0) &&
> +          keys.getSecond()[i].length > 0 ?
>             keys.getSecond()[i] : stopRow;
>         InputSplit split = new TableSplit(table.getTableName(),
>           splitStart, splitStop, regionLocation);
>
>
>

Mime
View raw message