hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2029) Reduce shell exception dump on console
Date Sat, 05 Dec 2009 21:36:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786511#action_12786511
] 

stack commented on HBASE-2029:
------------------------------

On doc'ing shell stuff, I did it a while ago: http://wiki.apache.org/hadoop/Hbase/Shell (See
Useful tricks on the end).  No one reads doc though so need to get it in closer to the shell
help some how.   Perhaps when we refactor help so its help by command instead of a single-page
dump.   On removing the stack-trace, I'd say leave it.  All kinds of exception cross the ipc
bridge.  For most cases, it'll be fine if no stack trace just the raw message but for the
odd one that is just an IOE with a cryptic message, context would be important. Yours and
J-D's improvements have brought us a long way already.  Its good enough I'd say to commit
leaving the patch in?  Do you have to make v5 or can I commit v2 and j-d's change?

> Reduce shell exception dump on console
> --------------------------------------
>
>                 Key: HBASE-2029
>                 URL: https://issues.apache.org/jira/browse/HBASE-2029
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: scripts
>    Affects Versions: 0.20.2
>            Reporter: Lars George
>            Assignee: Jean-Daniel Cryans
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HBASE-2029-hirb-v2.patch, HBASE-2029-hirb-v3.patch, HBASE-2029-hirb-v4.patch,
HBASE-2029-hirb.patch, HBASE-2029.patch
>
>
> As discussed on IRC and seen over and over, the shell is too verbose when it prints Java
related exceptions. The huge stack trace on the console is often causing more harm then actually
helping.
> {noformat}
> ...
> [11:31pm] larsgeorge:
> the only concern is to keep it in sync with new changes and also reduce its stacktrace
> [11:31pm] larsgeorge:
> that can be quite nasty
> [11:31pm] _dodger_:
> I've seen a prime example of that on the mailing list today
> [11:32pm] larsgeorge:
> yeah, those do repeat themselves
> [11:32pm] larsgeorge:
> also that DEBUG is on by default
> [11:33pm] larsgeorge:
> mind you, that is a good idea for the daemons
> [11:33pm] larsgeorge:
> but prolly not the shell
> [11:33pm] jdcryans:
> I was thinking
> [11:33pm] larsgeorge:
> maybe we can set ERROR logging level just for the shell when it is started?
> [11:34pm] jdcryans:
> we should stop printing the stack trace for NSRE
> [11:34pm] larsgeorge:
> there are a few others of that sort
> [11:34pm] larsgeorge:
> be it ZK reconnects etc.
> [11:35pm] jdcryans:
> yeah there's a lot of hbase-generated zk-related noise
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message