hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2068) MetricsRate is missing "registry" parameter
Date Wed, 30 Dec 2009 20:56:29 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795446#action_12795446
] 

Gary Helmling commented on HBASE-2068:
--------------------------------------

It looks like MetricsRate is not going to work with the Hadoop dynamic MBean support for JMX

Trying out this patch, I get this message in logs:
2009-12-30 14:43:45,010 ERROR org.apache.hadoop.metrics.MetricsUtil: unknown metrics type:
org.apache.hadoop.hbase.metrics.MetricsRate

and the requests attributes do not show up in JConsole for the RS or master stats.  Traced
the log message back to org.apache.hadoop.metrics.util.MetricsDynamicMBeanBase:

{code}
    for (MetricsBase o : metricsRegistry.getMetricsList()) {

      if (MetricsTimeVaryingRate.class.isInstance(o)) {
      ...
      }  else if ( MetricsIntValue.class.isInstance(o) || MetricsTimeVaryingInt.class.isInstance(o)
) {
      ...
      } else if ( MetricsLongValue.class.isInstance(o) || MetricsTimeVaryingLong.class.isInstance(o)
) {
      ...
      } else {
        MetricsUtil.LOG.error("unknown metrics type: " + o.getClass().getName());
      }
{code}

So for this to work with JMX, we'll need to extend MetricsDynamicMBeanBase with another class
that understands MetricsRate.  I'll pull together a patch for that.

> MetricsRate is missing "registry" parameter
> -------------------------------------------
>
>                 Key: HBASE-2068
>                 URL: https://issues.apache.org/jira/browse/HBASE-2068
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.2
>            Reporter: Lars George
>            Assignee: Lars George
>            Priority: Minor
>             Fix For: 0.20.3, 0.21.0
>
>         Attachments: HBASE-2068-0.20.patch, HBASE-2068.patch
>
>
> I am trying to get the graphing going using Edward Capriolo's great JMX to Cacti [guide|http://www.jointhegrid.com/hadoop/].
I checked and I am missing the request rate in the JMX MBean:
> {noformat}
> # sh 0_20/regionserver/RegionServerStatistics.sh service:jmx:rmi:///jndi/rmi://foobar:10102/jmxrmi
controlRole mypass hadoop:name=RegionServerStatistics,service=RegionServer
> storefiles:493 blockCacheFree:139771296 storefileIndexSizeMB:102 memstoreSizeMB:0 stores:658
blockCacheCount:8400 
> regions:83 blockCacheHitRatio:0 blockCacheSize:717478944 atomicIncrementTimeNumOps:0
atomicIncrementTimeAvgTime:0 
> atomicIncrementTimeMinTime:-1 atomicIncrementTimeMaxTime:0 
> {noformat} 
> I checked the code and the difference between requests and the other attributes is that
MetricsRate does not register itself in the MetricsRegistry used by the dynamic MBean like
for example the MetricsLongValue does.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message