hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-2036) Use Configuration instead of HBaseConfiguration
Date Mon, 14 Dec 2009 18:55:20 GMT

    [ https://issues.apache.org/jira/browse/HBASE-2036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12790288#action_12790288

Enis Soztutar commented on HBASE-2036:

bq.It relates to HBASE-2027 and some other issues that deal with how HConnection's are cached
by the client. Right now, they use HBaseConfiguration as a key to a set of cached connections
and information. It looks like the patch removes equals() from HBaseConfiguration (but not
hashcode()) and then uses the hashcode as the key instead.
Yeah, the patch should not remove equals() and keep hashCode(). Since I have insufficient
background about HBASE-2027, I did not want to make any changes to any configuration-related
logic, so I think keeping hashcode as the key may work for now. But calculating the whole
hashcode() at every call seems a major overkill. Maybe we can cache the hashcode in the conf
itself so that the hash-code works much faster. Does it make sense? 

> Use Configuration instead of HBaseConfiguration 
> ------------------------------------------------
>                 Key: HBASE-2036
>                 URL: https://issues.apache.org/jira/browse/HBASE-2036
>             Project: Hadoop HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>         Attachments: hconf.patch
> HBaseConfiguration extends Configuration but does not add any functionality to it. The
only function is hashCode() which really should be refactored into Hadoop Configuration. 
> I think in all the places(especially in the client side)  HBase methods and classes should
accept Configuration rather than HBaseConfiguration. The creation of the configuration with
the right files (hbase-site and hbase-default) should not be encapsulated in a private method,
but in a public static one. 
> The issues has arisen in our nutch+hbase patch for which we include both nutch configuration
and hbase configurations. Moreover people may want to include separate project-specific configuration
files to their configurations without the need to be dependent on the HBaseConfiguration.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message