hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Francke (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1758) Extract interface out of HTable
Date Thu, 03 Dec 2009 14:47:20 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Lars Francke updated HBASE-1758:

    Attachment: HTableinterface.patch

Thanks stack. Next time I'll open a new ticket!

Two more things I found (attached a new patch, the old one is obsolete):

* Added documentation about what happens when incrementColumnValue is called and the specified
column doesn't exist. I've looked through the source code and I believe this to be correct
but I'd appreciate it if anyone could check. And please feel free to reword the text as I'm
not a native speaker
* Added the incrementColumnValue method that allows disabling the WAL for this call

There are a lot of methods in HTable that are not exposed in HTableInterface (getStartKeys,
isTableEnabled, getRegionsInfo etc.) but I suppose that is by design so I chose not to include

> Extract interface out of HTable
> -------------------------------
>                 Key: HBASE-1758
>                 URL: https://issues.apache.org/jira/browse/HBASE-1758
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Vaibhav Puranik
>             Fix For: 0.21.0
>         Attachments: HTableinterface-deletes.patch, HTableinterface.patch, HTableInterface.patch,
> As per discussions in Hackathon, we have extracted interface out of HTable and named
it as HTableInterface. This will make unit testing client code easier and simplify client
> It opens other possibilities such as creating a HTable that does not do any RPC calls,
MockHTable etc.
> HTablePool still returns HTable instances. But we have added a setter method for HTableInterfaceFactory
on it. Thus developers can write their own HTableInterfaceFactory impl to return their own
HTableInterface implementation. 
> I have assigned this issue to 0.21 but you may consider it to move it to 0.20 if possible.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message