Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 28347 invoked from network); 14 Nov 2009 01:04:04 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 14 Nov 2009 01:04:04 -0000 Received: (qmail 57324 invoked by uid 500); 14 Nov 2009 01:04:04 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 57293 invoked by uid 500); 14 Nov 2009 01:04:04 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 57102 invoked by uid 99); 14 Nov 2009 01:04:03 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Nov 2009 01:04:03 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Nov 2009 01:04:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A636F234C4DA for ; Fri, 13 Nov 2009 17:03:39 -0800 (PST) Message-ID: <1923031734.1258160619679.JavaMail.jira@brutus> Date: Sat, 14 Nov 2009 01:03:39 +0000 (UTC) From: "olivier gillet (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Commented: (HBASE-1979) MurmurHash does not yield the same results as the reference C++ implementation when size % 4 >= 2 In-Reply-To: <946603811.1258112979584.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777783#action_12777783 ] olivier gillet commented on HBASE-1979: --------------------------------------- The only use of the hash(...) function I found is in HRegionInfo.encodeRegionName (ryan, is that what you referred to?), but it seems to explicitly use JenkinsHash instead of Murmur. > MurmurHash does not yield the same results as the reference C++ implementation when size % 4 >= 2 > ------------------------------------------------------------------------------------------------- > > Key: HBASE-1979 > URL: https://issues.apache.org/jira/browse/HBASE-1979 > Project: Hadoop HBase > Issue Type: Bug > Components: util > Affects Versions: 0.20.1 > Reporter: olivier gillet > Assignee: olivier gillet > Priority: Trivial > Fix For: 0.21.0, 0.20.3 > > Attachments: HBASE-1979.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Last rounds of MurmurHash are done in reverse order. data[length - 3], data[length - 2] and data[length - 1] in the block processing the remaining bytes should be data[len_m +2], data[len_m + 1], data[len_m]. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.