hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1979) MurmurHash does not yield the same results as the reference C++ implementation when size % 4 >= 2
Date Sat, 14 Nov 2009 13:34:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777916#action_12777916
] 

Andrew Purtell commented on HBASE-1979:
---------------------------------------

I checked references before making the commit on trunk. HRI.encodeRegionName explicitly uses
JenkinsHash. I didn't see any generic use of Hash.hash(), or Hash.getInstance(). The only
user of MurmurHash is PE at the moment. 

> MurmurHash does not yield the same results as the reference C++ implementation when size
% 4 >= 2
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1979
>                 URL: https://issues.apache.org/jira/browse/HBASE-1979
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 0.20.1
>            Reporter: olivier gillet
>            Assignee: olivier gillet
>            Priority: Trivial
>             Fix For: 0.21.0, 0.20.3
>
>         Attachments: HBASE-1979.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Last rounds of MurmurHash are done in reverse order. data[length - 3], data[length -
2] and data[length - 1] in the block processing the remaining bytes should be data[len_m +2],
data[len_m + 1], data[len_m].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message