hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1977) Add ts and allow setting VERSIONS when scanning in shell
Date Fri, 13 Nov 2009 23:35:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777742#action_12777742
] 

stack commented on HBASE-1977:
------------------------------

I backed out this bit:

{code}
@@ -429,7 +431,7 @@
           qualifier = String.from_java_bytes kv.getQualifier()
           column = family + ':' + qualifier
           cell = toString(column, kv, maxlength)
-          @formatter.row([row, "column=%s, %s" % [column, cell]])
+          @formatter.row([row, "column=%s, ts=%d, %s" % [column, kv.getTimestamp(), cell]])
         end
       end
       @formatter.footer(now, count)
{code}

We already have a 'timestamp='.  Above was superfluous.

> Add ts and allow setting VERSIONS when scanning in shell
> --------------------------------------------------------
>
>                 Key: HBASE-1977
>                 URL: https://issues.apache.org/jira/browse/HBASE-1977
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 0.21.0
>
>
> Small fix: 
> {code}
> Index: bin/HBase.rb
> ===================================================================
> --- bin/HBase.rb        (revision 835748)
> +++ bin/HBase.rb        (working copy)
> @@ -384,6 +384,7 @@
>          timestamp = args["TIMESTAMP"] || nil
>          columns = args["COLUMNS"] || getAllColumns()
>          cache = args["CACHE_BLOCKS"] || true
> +        versions = args["VERSIONS"] || 1
>          
>          if columns.class == String
>            columns = [columns]
> @@ -410,6 +411,7 @@
>            scan.setTimeStamp(timestamp)
>          end
>          scan.setCacheBlocks(cache)
> +        scan.setMaxVersions(versions) if versions > 1
>        else
>          scan = Scan.new()
>        end
> @@ -429,7 +431,7 @@
>            qualifier = String.from_java_bytes kv.getQualifier()
>            column = family + ':' + qualifier
>            cell = toString(column, kv, maxlength)
> -          @formatter.row([row, "column=%s, %s" % [column, cell]])
> +          @formatter.row([row, "column=%s, ts=%d, %s" % [column, kv.getTimestamp(),
cell]])
>          end
>        end
>        @formatter.footer(now, count)
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message