hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1906) FilterList of prefix and columnvalue not working properly with deletes and multiple values
Date Wed, 14 Oct 2009 05:55:32 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765412#action_12765412
] 

stack commented on HBASE-1906:
------------------------------

@jgray What seems to be happening is that we can exit the loop in HRegion#nextInternal without
a call to filterRow.  W/o this call, stuff is left in when we exit via:

{code}
        if (filter != null && filter.filterRowKey(row, 0, row.length)) {
          if (!results.isEmpty() && !Bytes.equals(currentRow, row)) {
            return true;
          }
{code}

Its as though this test should be done first:

{code}
        if (!Bytes.equals(currentRow, row)) {
{code}

... before we see if a row should be filtered out based off row key.

If filtered out by filterRowKey, then need to run filterRow on results already accumulated
somehow.

Will keep digging but input if any appreciated.

That deletes can come out of the peek seems fine after looking at it some... 


> FilterList of prefix and columnvalue not working properly with deletes and multiple values
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1906
>                 URL: https://issues.apache.org/jira/browse/HBASE-1906
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.2, 0.21.0
>
>         Attachments: 1906-v2.patch, filterlist.patch
>
>
> Attached are some unit tests from client and region that demonstrate the failing issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message