Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1756224368.1253048158319.JavaMail.jira@brutus>
Date: Tue, 15 Sep 2009 13:55:58 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Commented: (HBASE-1818) HFile code review and refinement
In-Reply-To: <1333397383.1252335657798.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12755685#action_12755685 ] 

stack commented on HBASE-1818:
------------------------------

Ok on 1. and 2 (I opened new issue to account for the case you discovered in your review where its possible we miss a key if many instances and they span a block -- hbase-1841).

What about this change:

{code}
@@ -860,7 +859,7 @@
       if (trailer.metaIndexCount == 0) {
         return null; // there are no meta blocks
       }
-      if (metaIndex == null) {
+      if ((metaIndex == null) || (metaIndex.count == 0)) {
         throw new IOException("Meta index not loaded");
       }
       byte [] mbname = Bytes.toBytes(metaBlockName);

{code}

Is it possible that metaIndex is loaded but empty?

Thanks Schubert

> HFile code review and refinement
> --------------------------------
>
>                 Key: HBASE-1818
>                 URL: https://issues.apache.org/jira/browse/HBASE-1818
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.0
>            Reporter: Schubert Zhang
>            Assignee: Schubert Zhang
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: HFile-v3.patch, HFile-v4.patch
>
>
> HFile is a good mimic of Google's SSTable file format. And we want HFile to become a common file format of hadoop in the near future.
> We will review the code of HFile and record the comments here, and then provide fixed patch after the review.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.