hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1722) Add support for exporting HBase metrics via JMX
Date Thu, 10 Sep 2009 04:53:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753420#action_12753420
] 

stack commented on HBASE-1722:
------------------------------

Thanks for the new patch Gary.  I took a look at it.  I like the addition of HBASE_REGIONSERVER_OPTIONS,
etc., only I think itneeds more work; it works for setting jmx options per daemon but would
be sweet if could set jvm mx and ms per daemon (and for zookeeper) as per HBASE-1687.  Its
a little tricky because we have that HBASE_HEAPSIZE thingy.

But no biggie.  You have done the work documenting how to make jmx run with your additions
to the metrics page.  Let me commit.  Folks who want to jmx can just read your metrics additions.
 'll commit to TRUNK.  I won't add to branch, unless you insist.  Lets fix the above in a
new issue or as part of HBASE-1687.

When we add suggested jmx options to hbase-env.sh, maybe default should be no default?   Its
a bit easier than pointing to a file with user login and password for jconsole?

Good stuff Gary.

> Add support for exporting HBase metrics via JMX
> -----------------------------------------------
>
>                 Key: HBASE-1722
>                 URL: https://issues.apache.org/jira/browse/HBASE-1722
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: ipc, master, regionserver
>    Affects Versions: 0.19.3
>            Reporter: Gary Helmling
>            Priority: Minor
>             Fix For: 0.20.1
>
>         Attachments: hbase-bin.patch, jmx_metrics-0.19.patch, jmx_support-trunk.patch,
metrics_docs_0.19.patch, metrics_docs_trunk.patch
>
>
> Current HBase metrics collection and reporting (for the 0.19 releases at least) doesn't
seem to export any of the metrics as MBeans via JMX.
> This patch adds JMX MBean support for reporting metrics collected in 3 areas:
> * org.apache.hadoop.hbase.ipc.HBaseRpcMetrics
> * org.apache.hadoop.hbase.master.metrics.MasterMetrics
> * org.apache.hadoop.hbase.regionserver.metrics.RegionServerMetrics
> This patch is only against the 0.19 branch, as the metrics API seems to have changed
a bit in Hadoop 0.20, including adding support for dynamic MBeans.  I'll add a patch reworked
for trunk shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message