hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Schubert Zhang (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1818) HFile code review and refinement
Date Tue, 15 Sep 2009 16:33:57 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Schubert Zhang updated HBASE-1818:

    Status: Patch Available  (was: Reopened)

Thanks for you reply. So I will make following decision to close this issue.

1. Do not check the returned buf  of decompress() and let NPE is throwed.
     I have thought to throw IOException, but it seems it is not a RunTimeException.

2. Leave the HFile can accept duplicated keys. But I think that will let the scenario of Scanner
    The block index uses firstKey of the block.

So, finally, the patch only include some minor fix.

> HFile code review and refinement
> --------------------------------
>                 Key: HBASE-1818
>                 URL: https://issues.apache.org/jira/browse/HBASE-1818
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.0
>            Reporter: Schubert Zhang
>            Assignee: Schubert Zhang
>            Priority: Minor
>             Fix For: 0.21.0
>         Attachments: HFile-v3.patch, HFile-v4.patch
> HFile is a good mimic of Google's SSTable file format. And we want HFile to become a
common file format of hadoop in the near future.
> We will review the code of HFile and record the comments here, and then provide fixed
patch after the review.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message