hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eric Tschetter (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1865) 0.20.0 TableInputFormatBase NPE
Date Thu, 24 Sep 2009 22:46:16 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eric Tschetter updated HBASE-1865:
----------------------------------

    Description: 
Spot the bug in this code:

public List<InputSplit> getSplits(JobContext context) throws IOException {
    byte [][] startKeys = table.getStartKeys();
    if (startKeys == null || startKeys.length == 0) {
      throw new IOException("Expecting at least one region.");
    }
    if (table == null) {
      throw new IOException("No table was provided.");
    }
...
}

Should check if the table is null before calling a method on it.

Admittedly, this isn't the worst bug in the world, it's really just more of a nuisance in
that the "No table was provided" message becomes an NPE

This bug is in both

org.apache.hadoop.hbase.mapred.TableInputFormatBase
org.apache.hadoop.hbase.mapreduce.TableInputFormatBase

  was:
Spot the bug in this code:

public List<InputSplit> getSplits(JobContext context) throws IOException {
    byte [][] startKeys = table.getStartKeys();
    if (startKeys == null || startKeys.length == 0) {
      throw new IOException("Expecting at least one region.");
    }
    if (table == null) {
      throw new IOException("No table was provided.");
    }
...
}

Should check if the table is null before calling a method on it.

Admittedly, this isn't the worst bug in the world, it's really just more of a nuisance in
that the "No table was provided" message becomes an NPE


> 0.20.0 TableInputFormatBase NPE
> -------------------------------
>
>                 Key: HBASE-1865
>                 URL: https://issues.apache.org/jira/browse/HBASE-1865
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Eric Tschetter
>         Attachments: 1865.patch
>
>
> Spot the bug in this code:
> public List<InputSplit> getSplits(JobContext context) throws IOException {
>     byte [][] startKeys = table.getStartKeys();
>     if (startKeys == null || startKeys.length == 0) {
>       throw new IOException("Expecting at least one region.");
>     }
>     if (table == null) {
>       throw new IOException("No table was provided.");
>     }
> ...
> }
> Should check if the table is null before calling a method on it.
> Admittedly, this isn't the worst bug in the world, it's really just more of a nuisance
in that the "No table was provided" message becomes an NPE
> This bug is in both
> org.apache.hadoop.hbase.mapred.TableInputFormatBase
> org.apache.hadoop.hbase.mapreduce.TableInputFormatBase

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message