hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Schubert Zhang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1818) HFile code review and refinement
Date Wed, 09 Sep 2009 07:35:57 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12752963#action_12752963

Schubert Zhang commented on HBASE-1818:

I am puzzled......

In the class HeapByteBuffer:

    public ByteBuffer compact() {
	System.arraycopy(hb, ix(position()), hb, ix(0), remaining());
	return this;

We can see there is a arraycopy here. But I am puzzled why the performance is no improvement?


I am nearly 100% sure that code block I added to solve a NPE. 
Could you please tell me about your added code block to solve the NPE? I am interested in

> HFile code review and refinement
> --------------------------------
>                 Key: HBASE-1818
>                 URL: https://issues.apache.org/jira/browse/HBASE-1818
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: io
>    Affects Versions: 0.20.0
>            Reporter: Schubert Zhang
>            Assignee: Schubert Zhang
>            Priority: Minor
>             Fix For: 0.20.1
>         Attachments: HFile-v1.patch, HFile-v2.patch
> HFile is a good mimic of Google's SSTable file format. And we want HFile to become a
common file format of hadoop in the near future.
> We will review the code of HFile and record the comments here, and then provide fixed
patch after the review.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message