hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HBASE-1739) hbase-1683 broke splitting; only split three logs no matter what N was.
Date Mon, 03 Aug 2009 23:23:14 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1739?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

stack resolved HBASE-1739.
--------------------------

       Resolution: Fixed
    Fix Version/s: 0.20.0

Applied trunk and 0.20 branch.

> hbase-1683 broke splitting; only split three logs no matter what N was.
> -----------------------------------------------------------------------
>
>                 Key: HBASE-1739
>                 URL: https://issues.apache.org/jira/browse/HBASE-1739
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.0
>
>
> There's a hard-coding in HLog#splitLog that presumes we always read in batches of ten
logs:
> {code}
> Index: src/java/org/apache/hadoop/hbase/regionserver/HLog.java
> ===================================================================
> --- src/java/org/apache/hadoop/hbase/regionserver/HLog.java     (revision 799653)
> +++ src/java/org/apache/hadoop/hbase/regionserver/HLog.java     (working copy)
> @@ -860,7 +860,7 @@
>          // Stop at logfiles.length when it's the last step
>          int endIndex = step == maxSteps - 1? logfiles.length: 
>            step * concurrentLogReads + concurrentLogReads;
> -        for (int i = (step * 10); i < endIndex; i++) {
> +        for (int i = (step * concurrentLogReads); i < endIndex; i++) {
>            // Check for possibly empty file. With appends, currently Hadoop 
>            // reports a zero length even if the file has been sync'd. Revisit if
>            // HADOOP-4751 is committed.
> {code}
> When I changed it so we default to reading 3 files at a time rather than 10 over in hbase-1683,
the hard-coding made it so we didn't read all logs.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message