hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ken Weiner (JIRA)" <j...@apache.org>
Subject [jira] Created: (HBASE-1762) Remove concept of ZooKeeper from HConnection interface
Date Wed, 12 Aug 2009 18:07:14 GMT
Remove concept of ZooKeeper from HConnection interface
------------------------------------------------------

                 Key: HBASE-1762
                 URL: https://issues.apache.org/jira/browse/HBASE-1762
             Project: Hadoop HBase
          Issue Type: Improvement
          Components: client
    Affects Versions: 0.20.0
            Reporter: Ken Weiner


The concept of ZooKeeper is really an implementation detail and should not be exposed in the
{{HConnection}} interface.   Therefore, I suggest removing the {{HConnection.getZooKeeperWrapper()}}
method from the interface. 

I couldn't find any uses of this method within the HBase code base except for in one of the
unit tests: {{org.apache.hadoop.hbase.TestZooKeeper}}.  This unit test should be changed to
instantiate the implementation of {{HConnection}} directly, allowing it to use the {{getZooKeeperWrapper()}}
method.  This requires making {{org.apache.hadoop.hbase.client.HConnectionManager.TableServers}}
public.  (I actually think TableServers should be moved out into an outer class, but in the
spirit of small patches, I'll refrain from suggesting that in this issue).

I'll attach a patch for:

# The removal of {{HConnection.getZooKeeperWrapper()}}
# Change of {{TableServers}} class from private to public
# Direct instantiation of {{TableServers}} within {{TestZooKeeper}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message