hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1780) HTable.flushCommits clears write buffer in finally clause
Date Thu, 27 Aug 2009 16:54:59 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748442#action_12748442
] 

stack commented on HBASE-1780:
------------------------------

Ryan makes the valid point offline that HTable should NOT be shared by threads.  If its all
synchronized on the write, then no performance gain sharing the HTable instance.   That'd
mean, remove all synchronization, flag HTable as not thread-safe and just add the bit where
writes are not lost on exception.

> HTable.flushCommits clears write buffer in finally clause
> ---------------------------------------------------------
>
>                 Key: HBASE-1780
>                 URL: https://issues.apache.org/jira/browse/HBASE-1780
>             Project: Hadoop HBase
>          Issue Type: Bug
>          Components: client
>         Environment: All
>            Reporter: Mathias Herberts
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1780.patch, HBASE-1780.patch
>
>
> Metthod flushCommits clears the write buffer in a finally clause.
> When using the write buffer, if the call to processBatchOfRows done in flushCommits throws
an exception, the write buffer will be cleared thus potentially leading to loss of data on
the client side.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message