hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vaibhav Puranik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1758) Extract interface out of HTable
Date Wed, 12 Aug 2009 18:17:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12742504#action_12742504
] 

Vaibhav Puranik commented on HBASE-1758:
----------------------------------------

Stack, agreed with most of the comments.

In a java interface all the methods are public by default, that is why I haven't mentioned
the word public explicitly. 

In my opinion it is better to have the HTableFactory as a outer class. If somebody writes
a new HTablePool impl that returns HTable, this outer class will be beneficial.

I will submit the patch with all of the changes except the inner class one and explicitly
mentioning public in the interface.. Hope that's ok.

> Extract interface out of HTable
> -------------------------------
>
>                 Key: HBASE-1758
>                 URL: https://issues.apache.org/jira/browse/HBASE-1758
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Vaibhav Puranik
>             Fix For: 0.21.0
>
>         Attachments: HTableInterface.patch
>
>
> As per discussions in Hackathon, we have extracted interface out of HTable and named
it as HTableInterface. This will make unit testing client code easier and simplify client
API. 
> It opens other possibilities such as creating a HTable that does not do any RPC calls,
MockHTable etc.
> HTablePool still returns HTable instances. But we have added a setter method for HTableInterfaceFactory
on it. Thus developers can write their own HTableInterfaceFactory impl to return their own
HTableInterface implementation. 
> I have assigned this issue to 0.21 but you may consider it to move it to 0.20 if possible.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message