Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <683600937.1247053515457.JavaMail.jira@brutus>
Date: Wed, 8 Jul 2009 04:45:15 -0700 (PDT)
From: =?utf-8?Q?Do=C4=9Facan_G=C3=BCney_=28JIRA=29?= <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1627) TableInputFormatBase#nextKeyValue
 catches the wrong exception
In-Reply-To: <2050241844.1247053515363.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/HBASE-1627?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Do=C4=9Facan G=C3=BCney updated HBASE-1627:
---------------------------------

    Attachment: tableinput.patch

A simple patch to change catch clause to catch all IOException-s. Are there=
 any downsides to this? If an IOException is thrown, reset your scanner, tr=
y again and if it fails again your job fails. Makes sense to me :D

> TableInputFormatBase#nextKeyValue catches the wrong exception
> -------------------------------------------------------------
>
>                 Key: HBASE-1627
>                 URL: https://issues.apache.org/jira/browse/HBASE-1627
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Do=C4=9Facan G=C3=BCney
>            Priority: Minor
>         Attachments: tableinput.patch
>
>
> TableInputFormatBase#nextKeyValue only catches UnknownScannerException fr=
om Scanner.next. However, scanner may throw other exceptions:
> {code}
> /* from HTable.ClientScanner#next */
>           try {
>             values =3D getConnection().getRegionServerWithRetries(callabl=
e);
>           } catch (IOException e) {
>             if (e instanceof UnknownScannerException &&
>                 lastNext + scannerTimeout < System.currentTimeMillis()) {
>               ScannerTimeoutException ex =3D new ScannerTimeoutException(=
);
>               ex.initCause(e);
>               throw ex;
>             }
>             throw e;
>           }
> {code}
> Is there any reason why TIFB does not catch ScannerTimeoutException?

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.