Return-Path: Delivered-To: apmail-hadoop-hbase-dev-archive@minotaur.apache.org Received: (qmail 27942 invoked from network); 3 Jul 2009 00:51:59 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Jul 2009 00:51:59 -0000 Received: (qmail 58394 invoked by uid 500); 3 Jul 2009 00:52:09 -0000 Delivered-To: apmail-hadoop-hbase-dev-archive@hadoop.apache.org Received: (qmail 58340 invoked by uid 500); 3 Jul 2009 00:52:09 -0000 Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hbase-dev@hadoop.apache.org Delivered-To: mailing list hbase-dev@hadoop.apache.org Received: (qmail 58330 invoked by uid 99); 3 Jul 2009 00:52:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jul 2009 00:52:09 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Jul 2009 00:52:07 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 31B5F234C004 for ; Thu, 2 Jul 2009 17:51:47 -0700 (PDT) Message-ID: <1979653917.1246582307187.JavaMail.jira@brutus> Date: Thu, 2 Jul 2009 17:51:47 -0700 (PDT) From: "Nitay Joffe (JIRA)" To: hbase-dev@hadoop.apache.org Subject: [jira] Updated: (HBASE-1596) Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher. In-Reply-To: <1766993369.1246420127173.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HBASE-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nitay Joffe updated HBASE-1596: ------------------------------- Attachment: hbase-1596.patch This patch removes WatcherWrapper, forcing all users of ZooKeeperWrapper to pass in a Watcher at construction time. This is to better force the users of the class to handle things like session expired. Currently the only user of ZooKeeperWrapper that doesn't pass in a Watcher is the Master. This adds an empty one. There is a separate jira, HBASE-1575, to handle session expired on the master. The rest (RegionServer, TableServers) are already passing in a watcher and handling session expired. > Remove WatcherWrapper and have all users of ZooKeeperWrapper supply a Watcher. > ------------------------------------------------------------------------------ > > Key: HBASE-1596 > URL: https://issues.apache.org/jira/browse/HBASE-1596 > Project: Hadoop HBase > Issue Type: Bug > Reporter: Nitay Joffe > Assignee: Nitay Joffe > Fix For: 0.20.0 > > Attachments: hbase-1596.patch > > > We originally wrote a WatcherWrapper for our ZooKeeperWrapper which cuts through some of the ZooKeeper interface so that we wouldn't have to supply Watchers everywhere. Now that we're having to deal with things like Session Expired all over the place, this class should no longer be used. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.