Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1960074651.1247620514782.JavaMail.jira@brutus>
Date: Tue, 14 Jul 2009 18:15:14 -0700 (PDT)
From: "Jonathan Gray (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1655) Usability improvements to HTablePool
In-Reply-To: <1901009354.1247601194943.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1655:
---------------------------------

    Attachment: HBASE-1655-v2-partial.patch

This doesn't include any stargate stuff, only issues there are the tab issues, reordering, and whether to expose the pools or not.

I'm not sure we want to remove the ability to work with HTablePool directly or not.

This patch re-publics a bunch of stuff, cuts down on the API quite a bit, and reduces re-instantiation of HBC when getting pools that already exist and will always reuse the original when getting tables.  We should definitely keep that.

Otherwise the changes are open to discussion, I'm not particularly sold on my own patch, just providing it so we have a point of reference for discussion.

The biggest thing to figure out is whether we even expose HTablePool non-statically to the user.  If not, we go down the path of a much longer easy-to-use API...

/me sleeping on it

> Usability improvements to HTablePool
> ------------------------------------
>
>                 Key: HBASE-1655
>                 URL: https://issues.apache.org/jira/browse/HBASE-1655
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Ken Weiner
>         Attachments: HBASE-1655-v2-partial.patch, HBASE-1655.patch
>
>
> A discussion on the HBase user mailing list (http://markmail.org/thread/7leeha56ny5mwecg) led to some suggested improvements for the org.apache.hadoop.hbase.client.HTablePool class.
> I will be submitting a patch that contains the following changes to HTablePool:
> * Remove constructors that were not used.
> * Change access to remaining contstructor from public to private to enforce use of the static factory method getPool.
> * Change internal map from TreeMap to HashMap because I couldn't see any reason it needed to be sorted.
> * Remove HBaseConfiguration and tableName member variables since they aren't really properties of the pool itself. They are associated with the HTable that should get instantiated when one is requested from the pool, but not already there.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.