Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1845399407.1247438834797.JavaMail.jira@brutus>
Date: Sun, 12 Jul 2009 15:47:14 -0700 (PDT)
From: =?utf-8?Q?Do=C4=9Facan_G=C3=BCney_=28JIRA=29?= <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1647) Filter#filterRow is called too often,
 filters rows it shouldn't have
In-Reply-To: <957193459.1247313914795.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


     [ https://issues.apache.org/jira/browse/HBASE-1647?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:all-tabpanel ]

Do=C4=9Facan G=C3=BCney updated HBASE-1647:
---------------------------------

    Attachment: HBASE-1647-v2.patch

v2 of patch.

I think all reset()s should be moved into RegionScanner#next as well. Since=
 we merge different columns of the same row in RegionScanner, calling reset=
 anywhere else (especiall in ScanQueryMatcher, which is called from StoreSc=
anner#next) seems like a bug.

> Filter#filterRow is called too often, filters rows it shouldn't have
> --------------------------------------------------------------------
>
>                 Key: HBASE-1647
>                 URL: https://issues.apache.org/jira/browse/HBASE-1647
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Do=C4=9Facan G=C3=BCney
>         Attachments: HBASE-1647-v2.patch, ScanBug.java, scanfilter.patch
>
>
> Filter#filterRow is called from ScanQueryMatcher#filterEntireRow which is=
 called from StoreScanner.next. However, if I understood the code correctly=
, StoreScanner processes KeyValue-s in a column-oriented order (i.e. after =
row1-col1 comes row2-col1, not row1-col2). Thus, when filterEntireRow is ca=
lled, in reality, the filter only processed (via filterKeyValue) only one c=
olumn of a row.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.