hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HBASE-1615) HBASE-1597 introduced a bug when compacting after a split
Date Tue, 07 Jul 2009 02:54:14 GMT

     [ https://issues.apache.org/jira/browse/HBASE-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jonathan Gray updated HBASE-1615:
---------------------------------

    Attachment: HBASE-1615-v5.patch

Changes implementation of how we're going to not cache blocks.

No more CompactionReader.  We now pass a boolean in when we create the HFile.Reader.Scanner
as to whether we want to cache blocks or not.  That is passed in to the HFile.Reader.readBlock().

Much more simple and avoids code duplication and unnecessary complexity.  If we decide to
make more optimizations to the reader or scanner, we will revisit this down the road.  Need
to stabilize trunk!

Passes new unit test introduced in 1616.

This patch takes out a bunch of debugging stuff added by stack's patches.  Only for clarity
purposes and so I could track where I was at.

> HBASE-1597 introduced a bug when compacting after a split
> ---------------------------------------------------------
>
>                 Key: HBASE-1615
>                 URL: https://issues.apache.org/jira/browse/HBASE-1615
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Jonathan Gray
>            Assignee: stack
>             Fix For: 0.20.0
>
>         Attachments: 1615-v2.patch, 1615-v3.patch, HBASE-1615-v4.patch, HBASE-1615-v5.patch,
hfile.patch
>
>
> The way HBASE-1597 instantiated the CompactionReader ignored whether the Reader it came
from was a half reader or not.
> Need to reimplement CompactionReader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message