hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Gray (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1655) Usability improvements to HTablePool
Date Thu, 16 Jul 2009 22:48:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732217#action_12732217
] 

Jonathan Gray commented on HBASE-1655:
--------------------------------------

I'm +1 on the changes described.  I'm not a big fan of putting a big comment in the HTable
constructor javadoc about being able to pass it a null.

IMO Something like that belongs in a // comment in the code, not exposed in the javadoc of
the most client-facing class we have.  It's for developers, not users.  Users who pass a null
HBC will soon learn that this will not work, why do they care about unit testing?

> Usability improvements to HTablePool
> ------------------------------------
>
>                 Key: HBASE-1655
>                 URL: https://issues.apache.org/jira/browse/HBASE-1655
>             Project: Hadoop HBase
>          Issue Type: Improvement
>          Components: client
>            Reporter: Ken Weiner
>            Assignee: Ken Weiner
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1655-HTablePool-commented.patch, HBASE-1655-v2-partial.patch,
HBASE-1655-v3.patch, HBASE-1655.patch
>
>
> A discussion on the HBase user mailing list (http://markmail.org/thread/7leeha56ny5mwecg)
led to some suggested improvements for the org.apache.hadoop.hbase.client.HTablePool class.
> I will be submitting a patch that contains the following changes to HTablePool:
> * Remove constructors that were not used.
> * Change access to remaining contstructor from public to private to enforce use of the
static factory method getPool.
> * Change internal map from TreeMap to HashMap because I couldn't see any reason it needed
to be sorted.
> * Remove HBaseConfiguration and tableName member variables since they aren't really properties
of the pool itself. They are associated with the HTable that should get instantiated when
one is requested from the pool, but not already there.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message