hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1647) Filter#filterRow is called too often, filters rows it shouldn't have
Date Wed, 15 Jul 2009 17:48:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731588#action_12731588
] 

stack commented on HBASE-1647:
------------------------------

.bq I have removed all test methods in TestStoreScanner as most of the filter methods are
now called in RegionScanner. Should I also refactor the test methods to TestScanner?

Tests are kinda critical for this infrequently used but critical feature.

But this issue is more about how the new filter Interface works, fixing the context at which
each of the filter methods are called.  Lets get that worked out first before we work on tests.

.bq On TestScanner#testStopRow.... 1 vs 0

That looks right.

On the javadoc change, I don't see it in the patch.

Otherwise, patch looks good to me.  Let me kick Ryan and get him to review it.






> Filter#filterRow is called too often, filters rows it shouldn't have
> --------------------------------------------------------------------
>
>                 Key: HBASE-1647
>                 URL: https://issues.apache.org/jira/browse/HBASE-1647
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Doğacan Güney
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1647-v2.patch, HBASE-1647-v3.patch, HBASE-1647-v4.patch, ScanBug.java,
scanfilter.patch
>
>
> Filter#filterRow is called from ScanQueryMatcher#filterEntireRow which is called from
StoreScanner.next. However, if I understood the code correctly, StoreScanner processes KeyValue-s
in a column-oriented order (i.e. after row1-col1 comes row2-col1, not row1-col2). Thus, when
filterEntireRow is called, in reality, the filter only processed (via filterKeyValue) only
one column of a row.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message