hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1627) TableInputFormatBase#nextKeyValue catches the wrong exception
Date Fri, 10 Jul 2009 18:09:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12729748#action_12729748
] 

stack commented on HBASE-1627:
------------------------------

Because near everything is an IOE at its base in hbase, its hard to distingush the retryable
from the IOE that is fatal.   My fear is that if we make the catch overly broad, it will retry
for ever rather than fail.  If OK with you, I'll commit STE instead of IOE?  Thats a fix for
a breakage.  We can keep an eye on this and if other IOE subclasses that can bear retry, lets
add them?

> TableInputFormatBase#nextKeyValue catches the wrong exception
> -------------------------------------------------------------
>
>                 Key: HBASE-1627
>                 URL: https://issues.apache.org/jira/browse/HBASE-1627
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Doğacan Güney
>            Priority: Minor
>         Attachments: tableinput.patch
>
>
> TableInputFormatBase#nextKeyValue only catches UnknownScannerException from Scanner.next.
However, scanner may throw other exceptions:
> {code}
> /* from HTable.ClientScanner#next */
>           try {
>             values = getConnection().getRegionServerWithRetries(callable);
>           } catch (IOException e) {
>             if (e instanceof UnknownScannerException &&
>                 lastNext + scannerTimeout < System.currentTimeMillis()) {
>               ScannerTimeoutException ex = new ScannerTimeoutException();
>               ex.initCause(e);
>               throw ex;
>             }
>             throw e;
>           }
> {code}
> Is there any reason why TIFB does not catch ScannerTimeoutException?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message