hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1663) Request compaction only once instead of every time 500ms each time we cycle the hstore.getStorefilesCount() > this.blockingStoreFilesNumber loop
Date Thu, 16 Jul 2009 19:02:14 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732086#action_12732086
] 

stack commented on HBASE-1663:
------------------------------

Here is change I want to commit:

{code}
Index: src/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
===================================================================
--- src/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java  (revision 794447)
+++ src/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java  (working copy)
@@ -229,13 +229,12 @@
       finished = true;
       for (Store hstore: region.stores.values()) {
         if (hstore.getStorefilesCount() > this.blockingStoreFilesNumber) {
-          // always request a compaction
-          server.compactSplitThread.compactionRequested(region, getName());
           // only log once
           if (!triggered) {
             LOG.info("Too many store files for region " + region + ": " +
               hstore.getStorefilesCount() + ", requesting compaction and " +
               "waiting");
+            this.server.compactSplitThread.compactionRequested(region, getName());
             triggered = true;
           }
           // pending compaction, not finished
{code}

> Request compaction only once instead of every time 500ms each time we cycle the hstore.getStorefilesCount()
> this.blockingStoreFilesNumber loop
> ------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-1663
>                 URL: https://issues.apache.org/jira/browse/HBASE-1663
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>             Fix For: 0.20.0
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message