hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Doğacan Güney (JIRA) <j...@apache.org>
Subject [jira] Commented: (HBASE-1627) TableInputFormatBase#nextKeyValue catches the wrong exception
Date Wed, 08 Jul 2009 21:51:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728920#action_12728920
] 

Doğacan Güney commented on HBASE-1627:
--------------------------------------

Yeah sure I can change it to STE but why is IOE being broad a problem? I mean, we catch the
IOE and recreate the scanner, try next()ing again and fail if there is an exception again.
Is there any scenario where this is harmful?

> TableInputFormatBase#nextKeyValue catches the wrong exception
> -------------------------------------------------------------
>
>                 Key: HBASE-1627
>                 URL: https://issues.apache.org/jira/browse/HBASE-1627
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Doğacan Güney
>            Priority: Minor
>         Attachments: tableinput.patch
>
>
> TableInputFormatBase#nextKeyValue only catches UnknownScannerException from Scanner.next.
However, scanner may throw other exceptions:
> {code}
> /* from HTable.ClientScanner#next */
>           try {
>             values = getConnection().getRegionServerWithRetries(callable);
>           } catch (IOException e) {
>             if (e instanceof UnknownScannerException &&
>                 lastNext + scannerTimeout < System.currentTimeMillis()) {
>               ScannerTimeoutException ex = new ScannerTimeoutException();
>               ex.initCause(e);
>               throw ex;
>             }
>             throw e;
>           }
> {code}
> Is there any reason why TIFB does not catch ScannerTimeoutException?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message