hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1597) Prevent unnecessary caching of blocks during compactions
Date Fri, 03 Jul 2009 01:17:47 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726761#action_12726761
] 

Andrew Purtell commented on HBASE-1597:
---------------------------------------

+1

I think this is good enough to retire this issue and move on. Any chance that CompactionReader
may acquire more function over time or be specialized? Having it as a separate reader class
would not necessarily be bad in that case. 

> Prevent unnecessary caching of blocks during compactions
> --------------------------------------------------------
>
>                 Key: HBASE-1597
>                 URL: https://issues.apache.org/jira/browse/HBASE-1597
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1597-v1.patch
>
>
> When running any kind of compaction, we read every block of every storefile being compacted
into the block cache.
> We would like to reuse any already cached blocks, if available, but otherwise we should
not bog down the LRU with unnecessary blocks.
> This is not as bad as it was with the old LRU because the latest LRU implementation (HBASE-1460)
is scan-resistant.  This ensures that we are not causing massive eviction of the blocks that
are being read multiple times or from in-memory tables.  However, this does add to the GC-woes
of an import because each block gets further referenced, and for longer periods of time. 
There is also overhead in running the LRU evictions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message