hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ryan rawson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1647) Filter#filterRow is called too often, filters rows it shouldn't have
Date Mon, 20 Jul 2009 08:11:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12733155#action_12733155
] 

ryan rawson commented on HBASE-1647:
------------------------------------

thanks for the updated patch. The tests need to be migrated not just deleted, but I'll poke
at the implementation and its consequences compared to the previous implementation tomorrow.
 I've posted it to github:

http://github.com/ryanobjc/hbase/commit/3b31d0f4b0c0df2ad519f421d35cbb216da054e1

> Filter#filterRow is called too often, filters rows it shouldn't have
> --------------------------------------------------------------------
>
>                 Key: HBASE-1647
>                 URL: https://issues.apache.org/jira/browse/HBASE-1647
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Doğacan Güney
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1647-v2.patch, HBASE-1647-v3.patch, HBASE-1647-v4.patch, HBASE-1647-v5.patch,
HBASE-1647-v6.patch, ScanBug.java, scanfilter.patch
>
>
> Filter#filterRow is called from ScanQueryMatcher#filterEntireRow which is called from
StoreScanner.next. However, if I understood the code correctly, StoreScanner processes KeyValue-s
in a column-oriented order (i.e. after row1-col1 comes row2-col1, not row1-col2). Thus, when
filterEntireRow is called, in reality, the filter only processed (via filterKeyValue) only
one column of a row.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message