hbase-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HBASE-1627) TableInputFormatBase#nextKeyValue catches the wrong exception
Date Wed, 08 Jul 2009 19:09:15 GMT

    [ https://issues.apache.org/jira/browse/HBASE-1627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728855#action_12728855
] 

stack commented on HBASE-1627:
------------------------------

IOE seems overly broad (almost everything is IOE at its base).

Above looks like a bug in TIFB.  It should have been changed to handle STE instead of USE.
 If you are good with making this change, I'll commit your patch changing your overly general
IOE to STE?

> TableInputFormatBase#nextKeyValue catches the wrong exception
> -------------------------------------------------------------
>
>                 Key: HBASE-1627
>                 URL: https://issues.apache.org/jira/browse/HBASE-1627
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Doğacan Güney
>            Priority: Minor
>         Attachments: tableinput.patch
>
>
> TableInputFormatBase#nextKeyValue only catches UnknownScannerException from Scanner.next.
However, scanner may throw other exceptions:
> {code}
> /* from HTable.ClientScanner#next */
>           try {
>             values = getConnection().getRegionServerWithRetries(callable);
>           } catch (IOException e) {
>             if (e instanceof UnknownScannerException &&
>                 lastNext + scannerTimeout < System.currentTimeMillis()) {
>               ScannerTimeoutException ex = new ScannerTimeoutException();
>               ex.initCause(e);
>               throw ex;
>             }
>             throw e;
>           }
> {code}
> Is there any reason why TIFB does not catch ScannerTimeoutException?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message