Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <506555903.1246327367404.JavaMail.jira@brutus>
Date: Mon, 29 Jun 2009 19:02:47 -0700 (PDT)
From: "Jonathan Gray (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1591) HBASE-1554 broke
 org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
In-Reply-To: <143697380.1246323887352.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1591:
---------------------------------

    Attachment: HBASE-1591-v1.patch

Cleans up TestLruBlockCache a great deal.  I was doing a lot of hard-coding of block sizes, cache sizes, etc... Was an imperfect science and not very portable.

I made LruBlockCache only have heapSize, not a separate cacheSize.  The unit tests are also fully testing the heap size tracking.

Any further work for sizing of this will be in HBASE-1590 though I'm not sure how necessary that is anymore.

> HBASE-1554 broke org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-1591
>                 URL: https://issues.apache.org/jira/browse/HBASE-1591
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1591-v1.patch
>
>
> Modification of LRU heap size calculations altered some of the test expectations in the LRU test.
> {noformat}
> Error Message
> expected:<0> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: expected:<0> but was:<1>
> 	at org.apache.hadoop.hbase.io.hfile.TestLruBlockCache.testResizeBlockCache(TestLruBlockCache.java:435)
> {noformat}
> Patch coming...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.