Mailing-List: contact hbase-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hbase-dev@hadoop.apache.org
Message-ID: <1435993833.1245797107418.JavaMail.jira@brutus>
Date: Tue, 23 Jun 2009 15:45:07 -0700 (PDT)
From: "Jonathan Gray (JIRA)" <jira@apache.org>
To: hbase-dev@hadoop.apache.org
Subject: [jira] Updated: (HBASE-1563) incrementColumnValue does not write to
 WAL
In-Reply-To: <389087572.1245691687385.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Gray updated HBASE-1563:
---------------------------------

    Attachment: HBASE-1563-v3.patch

- Removes unnecessary Get in client code
- Removed duplicate server calls in the client code, default just calls full w/ true
- Replaced increment javadoc with "Atomically increments a column value. If the column value already exists and is not a big-endian long, this could throw an exception."  Is that more clear?

@Ryan I got most the way through splitting up Store.incrementColumnValue logic so we figure out what we have to do first, then write to wal, then perform the insert.  The issue is when we increment in-place in the memcache.  If we truly don't want to write until the wal append, we'd have to make a copy of the KV, perform the increment on it, and then either increment the original memcache value or swap.  This more or less negates the in-place increment optimization.  Thoughts?

> incrementColumnValue does not write to WAL
> ------------------------------------------
>
>                 Key: HBASE-1563
>                 URL: https://issues.apache.org/jira/browse/HBASE-1563
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: Jonathan Gray
>            Assignee: Jonathan Gray
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1563-v1.patch, HBASE-1563-v2.patch, HBASE-1563-v3.patch
>
>
> Incrementing never writes to the WAL.  Under failure scenarios, you will lose all increments since the last flush.
> Do we want to expose the option to the client as to whether to write to WAL or not?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.